Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] atttypmod now 32 bits, interface change

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us (Tom Lane)
Cc: t-ishii(at)sra(dot)co(dot)jp, pgsql-interfaces(at)postgreSQL(dot)org, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] atttypmod now 32 bits, interface change
Date: 1998-07-22 15:10:42
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-interfaces
> Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Might be my atttypmod changes.  I did not make those version-sensitive. 
> > I will do that now.
> Yes, if we want to have backward compatibility as I just defined it,
> then the backend will have to send atttypmod as either 2 or 4 bytes
> depending on ProtocolVersion.  Shouldn't be too hard.  But I'm concerned
> that you and I both missed that initially.  We had better actually test
> that the current backend sources will work with a 6.3.2-release frontend.

Already done.  We never passed atttypmod to the backend before 6.4, so
the change it just to pass it or not pass it, and Tom already did that. 
The fact that the internal length was 2 and is not 4 is not relevant
because we never passed it to the frontend in the past.

	if (PG_PROTOCOL_MAJOR(FrontendProtocol) >= 2)
        	pq_putint(attrs[i]->atttypmod, sizeof(attrs[i]->atttypmod...

Bruce Momjian                          |  830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

In response to

pgsql-hackers by date

Next:From: Bruce TongDate: 1998-07-22 15:11:18
Subject: Re: [GENERAL] Re: [HACKERS] [Fwd: SGVLLUG Oracle and Informix on Linux]
Previous:From: Bruce TongDate: 1998-07-22 14:54:35
Subject: Re: [GENERAL] Re: [HACKERS] [Fwd: SGVLLUG Oracle and Informix on Linux]

pgsql-interfaces by date

Next:From: Chris WilliamsDate: 1998-07-22 16:43:57
Subject: Re: [INTERFACES] Win32 version of the psql library
Previous:From: Thomas G. LockhartDate: 1998-07-22 14:49:11
Subject: Re: [INTERFACES] Re: [HACKERS] atttypmod now 32 bits, interface change

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group