From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | daveh(at)insightdist(dot)com (David Hartwig) |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Current sources?t |
Date: | 1998-07-20 20:20:55 |
Message-ID: | 199807202020.QAA18656@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I did not get any attached patch. ??? I can check it out at home where I have cvsup.
Maybe I forgot to attach it.
>
> Where there any confirmed problems cause by the aggressive use of the junkfilter? I ask because, adding this extra
> check probably will not resolve them. It may only reduce the problem.
I did not address the problems. This will probably just reduce them.
>
> I was planning on including an additional check for resjunk as part of another patch I am working on. (GROUP/ORDER BY
> func(x) where func(x) is not in the targetlist) Graciously accepted.
>
>
This is the code fragment I added to execMain.c:
---------------------------------------------------------------------------
{
bool junk_filter_needed = false;
List *tlist;
if (operation == CMD_SELECT)
{
foreach(tlist, targetList)
{
TargetEntry *tle = lfirst(tlist);
if (tle->resdom->resjunk)
{
junk_filter_needed = true;
break;
}
}
}
if (operation == CMD_UPDATE || operation == CMD_DELETE ||
operation == CMD_INSERT ||
(operation == CMD_SELECT && junk_filter_needed))
{
--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Ivar Helbekkmo | 1998-07-20 20:25:32 | Re: [HACKERS] cidr |
Previous Message | Tom Lane | 1998-07-20 19:41:43 | Re: [HACKERS] s_lock.h busted |