found another overrun

From: Maurice Gittens <mgittens(at)david(dot)gits(dot)nl>
To: hackers(at)postgresql(dot)org
Subject: found another overrun
Date: 1998-03-29 12:33:21
Message-ID: 199803291233.OAA25342@david.gits.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
This simple patch to catalog/pg_type.c fixes a buffer overrun.
It was detected by Electric Fence and triggered by statements like:

SELECT * into table t from pg_database;

The system would crash on a memmove call in DataFile() with arguments like this:

memmove(0x0, 0x0, 0);

Here's the patch.

320a321
> NameData name;
390c391,392
< values[i++] = PointerGetDatum(typeName); /* 1 */
---
> namestrcpy(&name,typeName);
> values[i++] = NameGetDatum(&name); /* 1 */

After applying the patch the problem goes away.

I'll try to make all the buffer overruns detected by Electric Fence
during the regression test on my Linux system go away -:).
Debugging is a nice way to learn about a system isn't it?

With regards from Maurice.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michal Mosiewicz 1998-03-29 14:17:29 Re: [HACKERS] Optimizer fails?
Previous Message Bruce Momjian 1998-03-29 04:53:56 Re: (PM) Re: [HACKERS] Ways to crash the backend