Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: lockhart(at)alumni(dot)caltech(dot)edu (Thomas G(dot) Lockhart)
Cc: dschnabel(at)magnet(dot)at, hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible
Date: 1998-03-20 03:59:46
Message-ID: 199803200359.WAA24472@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> This is a multi-part message in MIME format.
> --------------5B2D8E5180AAC1149F41A1FA
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> > > So, the patch for "function() BETWEEN" helps, but I'm still not sure
> > > it is safe, since I don't know how these nodes might be handled
> > > deeper in the backend.
> >
> > Ship the patch over here and I will have a look at it.
>
> OK, here it is...

Applied. There is a nice comment, and it just prevents an elog(). I
think your logic is correct. There are several cases, I think, where
strings are used multiple places. Also, you are just preventing
reprocessing of the args. We can perhaps improve this later if a
problem comes up.

--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-03-20 04:20:53 Re: [HACKERS] tables >2GB
Previous Message Bruce Momjian 1998-03-20 03:53:33 Re: [HACKERS] Alpha initdb fixed!