Snapshot 26Feb98 - configure still broken

From: Andrew Martin <martin(at)biochemistry(dot)ucl(dot)ac(dot)uk>
To: scrappy(at)hub(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Snapshot 26Feb98 - configure still broken
Date: 1998-02-26 15:46:37
Message-ID: 199802261546.PAA13529@bsmir06.biochem.ucl.ac.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Just tried the 26Feb98 Snapshot under Irix 5.3.

If you request a compiler other than gcc, configure still dies.

After looking at Darren's comment:
>
> I complained about this one a few months back. There is a test condition
> that needs to be double-quoted. In my generated configure, it's at line
> #3230 in the test whether gcc needs -traditional.
>
> I seem to recall that it was more a bug in autoconf that in the postgres
> configure script.
>
> darrenk
>

I took another look and fixed the problem by hacking configure.
It clearly is a bug in the routine:
AC_PROG_GCC_TRADITIONAL

The only work around seems to be to hack configure after running autoconf
(or to fix autoconf...).

Here's a patch to configure which fixes the problem:

*** configure.orig Thu Feb 26 08:02:06 1998
--- configure Thu Feb 26 15:42:30 1998
***************
*** 3275,3281 ****
fi
rm -f conftest*

! if test $ac_cv_prog_gcc = yes; then
echo $ac_n "checking whether ${CC-cc} needs -traditional""... $ac_c" 1>&6
echo "configure:3281: checking whether ${CC-cc} needs -traditional" >&5
if eval "test \"`echo '$''{'ac_cv_prog_gcc_traditional'+set}'`\" = set"; then
--- 3275,3281 ----
fi
rm -f conftest*

! if test "$ac_cv_prog_gcc" = yes; then
echo $ac_n "checking whether ${CC-cc} needs -traditional""... $ac_c" 1>&6
echo "configure:3281: checking whether ${CC-cc} needs -traditional" >&5
if eval "test \"`echo '$''{'ac_cv_prog_gcc_traditional'+set}'`\" = set"; then

Andrew

----------------------------------------------------------------------------
Dr. Andrew C.R. Martin University College London
EMAIL: (Work) martin(at)biochem(dot)ucl(dot)ac(dot)uk (Home) andrew(at)stagleys(dot)demon(dot)co(dot)uk
URL: http://www.biochem.ucl.ac.uk/~martin
Tel: (Work) +44(0)171 419 3890 (Home) +44(0)1372 275775

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Martin 1998-02-26 16:31:55 Snapshot 26Feb98 - another minor showstopper
Previous Message Bruce Momjian 1998-02-26 14:44:34 Re: [HACKERS] MergeJoin and Mark/Restr scan positions (Re: [PORTS] Port Bug Report)