From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | tih(at)Hamartun(dot)Priv(dot)NO (Tom I Helbekkmo) |
Cc: | scrappy(at)hub(dot)org, goran(at)bildbasen(dot)se, hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] configure on linux |
Date: | 1998-02-05 00:08:49 |
Message-ID: | 199802050008.TAA01282@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> Bruce Momjian wrote:
>
> > Don't break my optimizations. The locking stuff is in *.h files for a
> > reason. They get called thousands of times, and inlining this code has
> > produced a good speedup and they aren't that big.
>
> You misunderstand me. I didn't suggest removing the S_LOCK() et al
> macros. What I meant was that the actual assembly implementation of
> tas() itself might be better off in a separate source file. As an
> example, here is my current version of the locking code for the VAX,
> in s_lock.h (bbssi is "branch on bit set and set, interlocked"):
Yes, I considered static functions, but that is assuming the compiler is
going to do something, and we can't really be sure of this. Better to
make it a macro, so there is no change of it not being inlined. Also, I
don't think asm stuff is re-ordered, so you don't have the 'volatile'
problem.
--
Bruce Momjian
maillist(at)candle(dot)pha(dot)pa(dot)us
From | Date | Subject | |
---|---|---|---|
Next Message | rw12922 | 1998-02-05 00:46:18 | unsubscribe |
Previous Message | ernst.molitor | 1998-02-04 23:13:48 | Linux: linux.s / tas.s not found... |