Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: vadim(at)sable(dot)krasnoyarsk(dot)su (Vadim B(dot) Mikheev)
Cc: matti(at)algonet(dot)se, hackers(at)postgreSQL(dot)org
Subject: Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')
Date: 1998-01-05 16:10:37
Message-ID: 199801051610.LAA11613@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I made all the error messages coming from the parser as ERROR, and
> > non-parser messages as ABORT. I think I will need to fine-tune the
> > messages because I am sure I missed some messages that should be ERROR
> > but are ABORT. For example, utils/adt messages about improper data
> > formats, is that an ERROR or an ABORT?
>
> Good question :)
>
> Following your way
>
> insert into X (an_int2_field) values (9999999999);
>
> should cause ERROR message, but
>
> insert into X (an_int2_field) select an_int4_field from Y;

This generates an ERROR, because the parser catches the type mismatch.

It looks like the changes are broken up pretty much among directories.
utils/adt and catalog/ and commands/ are all pretty much ERROR.

>
> should return ABORT message if value of some an_int4_field in Y is
> greater than 32768.
>
> Vadim
>

--
Bruce Momjian
maillist(at)candle(dot)pha(dot)pa(dot)us

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim B. Mikheev 1998-01-05 17:12:38 Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')
Previous Message Bruce Momjian 1998-01-05 15:41:41 Re: [HACKERS] Re: development