| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: WITH clause in CREATE STATISTICS |
| Date: | 2017-05-12 15:06:26 |
| Message-ID: | 19853.1494601586@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> I'm prepared to create a fix for that, but it'd be easier to commit the
>> current patch first, to avoid merge conflicts.
> It seems we're mostly in agreement regarding the parts I was touching.
> Do you want to push your version of the patch?
It's still almost all your work, so I figured you should push it.
>> Hm. OK, but then that example is pretty misleading, because it leads
>> the reader to suppose that the planner can tell the difference between
>> the selectivities of the two queries. Maybe what's lacking is an
>> explanation of how you'd use this statistics type.
> I think we should remove the complex example from that page, and instead
> refer the reader to chapters 14 and 69.
Seems reasonable. If we did add enough material there to be a standalone
description, it would be duplicative probably. However, that does put
the onus on the other chapters to offer a complete definition, rather
than leaving details to the man page as we do in many other cases.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-05-12 15:23:18 | Re: Cached plans and statement generalization |
| Previous Message | Alvaro Herrera | 2017-05-12 14:43:22 | Re: WITH clause in CREATE STATISTICS |