From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Move catalog toast table and index declarations |
Date: | 2020-10-27 11:42:58 |
Message-ID: | 1983ae60-5fde-8393-029d-ce016d5fce78@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-10-24 15:23, John Naylor wrote:
> This part created a syntax error:
>
> --- a/src/include/catalog/unused_oids
> +++ b/src/include/catalog/unused_oids
> @@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to
> $FindBin::RealBin: $!\n";
> use lib "$FindBin::RealBin/../../backend/catalog/";
> use Catalog;
>
> -my @input_files = (glob("pg_*.h"), qw(indexing.h));
> +my @input_files = (glob("pg_*.h");
OK, fixing that.
> Style: In genbki.h, "extern int no_such_variable" is now out of place.
> Also, the old comments like "The macro definitions are just to keep the
> C compiler from spitting up." are now redundant in their new setting.
Hmm, I don't really see what's wrong there. Do you mean the macro
definitions should be different, or the comments are wrong, or something
else?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2020-10-27 11:43:48 | Re: Yet another fast GiST build |
Previous Message | Bruce Momjian | 2020-10-27 11:40:00 | Re: Prevent printing "next step instructions" in initdb and pg_upgrade |