| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Supporting Windows SChannel as OpenSSL replacement |
| Date: | 2014-08-15 20:57:23 |
| Message-ID: | 19795.1408136243@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 08/15/2014 08:16 PM, Jeff Janes wrote:
>> Should the ereport DEBUG2 be inside the "#ifdef USE_SSL"?
> Yeah.
> I've been thinking though, perhaps we should always have the ssl_in_use,
> peer_cn and peer_cert_valid members in the Port struct. If not compiled
> with USE_SSL, they would just always be false/NULL. Then we wouldn't
> need #ifdefs around all the places that check hose fields either.
+1. This would also make it less risky for add-on code to touch the Port
struct.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Silva | 2014-08-15 21:20:39 | Re: jsonb format is pessimal for toast compression |
| Previous Message | Tom Lane | 2014-08-15 20:38:06 | Re: jsonb format is pessimal for toast compression |