| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: errbacktrace |
| Date: | 2019-07-22 20:10:58 |
| Message-ID: | 19774.1563826258@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Just noticing that ExceptionalCondition has an "fflush(stderr);"
> in front of what you added --- perhaps you should also add one
> after the backtrace_symbols_fd call? It's not clear to me that
> that function guarantees to fflush, nor do I want to assume that
> abort() does.
Oh, wait, it's writing to fileno(stderr) so it couldn't be
buffering anything. Disregard ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2019-07-22 20:23:22 | Re: Psql patch to show access methods info |
| Previous Message | Tom Lane | 2019-07-22 20:05:35 | Re: errbacktrace |