Skip site navigation (1) Skip section navigation (2)

Re: Refactoring of command.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>,John Gray <jgray(at)azuli(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Refactoring of command.c
Date: 2002-02-27 05:03:17
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Peter Eisentraut wrote:
>> John Gray writes:
> dbcommands.c	rename to database.c (see below)
> indexcmds.c	rename to index.c (see below)
>> Might as well keep these.  They don't hurt anyone just because they spell
>> a little differently.

> I disagree.  If we are cleaning, let's clean.  *cmd* is redundant.  The
> contents of the files will be quite different anyway.

But if we rename them, we will lose CVS history for the files (unless we
jump through hoops that typically are not jumped through).  I agree with
Peter: do not rename files simply to have slightly simpler file names.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2002-02-27 05:19:37
Subject: Re: Rename sequence bug/feature
Previous:From: Hannu KrosingDate: 2002-02-27 04:52:00
Subject: Re: eWeek Poll: Which database is most critical to your

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group