| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-05 16:38:36 |
| Message-ID: | 19736.1578242316@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Here's one final style cleanup for the TAP test.
LGTM, pushed.
One minor note: you wanted to change the \DRD test to
+check_completion("\\DRD\t", qr/\\drds /, "complete \\DRD<tab> to \\drds");
but that doesn't work everywhere, unfortunately. On my machine
what comes out is
# Actual output was "\\DRD\b\b\bdrds "
# Did not match "(?-xism:\\drds )"
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2020-01-05 16:48:18 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Previous Message | Tom Lane | 2020-01-05 16:35:52 | pgsql: Minor style improvements for tab-completion test. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2020-01-05 16:48:18 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Previous Message | Tomas Vondra | 2020-01-05 15:41:13 | Re: FETCH FIRST clause WITH TIES option |