Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

From: Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>, "mujeebskdev" <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>
Subject: Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer
Date: 2025-05-29 05:20:46
Message-ID: 1971a7c57b4.1297b81cb39817.6046746814569696904@zohocorp.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The entire point of having a wire protocol is that you can't/don't

> need to detect that.  The short answer here is that this is

> pgbouncer's bug and you should be nagging them to change, not us.

Assuming we've requested the PgBouncer team to stop abusing the server_version parameter for the special 'pgbouncer' database, and they’ve agreed to pass the actual PostgreSQL server version instead - this would prevent us from showing the usual warning, since the version would now appear to be > 9.2

But, still most of the psql features won't work here, right? Won't it be a false positive to not show the warning here? Please correct me if I'm wrong.

Thanks & Regards,
Shaik Mohammad Mujeeb
Member Technical Staff
https://www.zoho.com/

---- On Wed, 28 May 2025 04:51:05 +0530 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote ---

Shaik Mohammad Mujeeb < mailto:mujeeb(dot)sk(at)zohocorp(dot)com > writes:
> So, I feel that if we can reliably detect when the backend is a non-PostgreSQL server, it might be better to adjust the warning accordingly, rather than relying on a client-server version comparison in such cases.

The entire point of having a wire protocol is that you can't/don't
need to detect that. The short answer here is that this is
pgbouncer's bug and you should be nagging them to change, not us.

            regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2025-05-29 05:59:51 Re: Logical Replication of sequences
Previous Message Pavel Stehule 2025-05-29 05:11:40 backend_xmin is null in pg_stat_replication, although repl. slot change it