Re: [PATCHES] thousands comma numeric formatting in psql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Eugen Nedelcu <eugen(at)sifolt(dot)ro>
Subject: Re: [PATCHES] thousands comma numeric formatting in psql
Date: 2005-07-12 15:32:52
Message-ID: 19674.1121182372@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> This patch sounds quite a lot different from what I thought we had
>> agreed to, which was a way to specify that the client-side LC_NUMERIC
>> locale settings should be used for formatting numbers. I think the only
>> pset should be "locale on" or "locale not on". This business about
>> space is a red herring: if you want that, create a locale spec that
>> specifies it.

> Well, how many people have langinfo? I don't.

What's langinfo got to do with it? To minimize our portability
exposure, the patch should use the same facilities that
src/backend/utils/adt/pg_locale.c already depends on, namely
setlocale() and localeconv().

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-07-12 15:50:46 Re: [PATCHES] thousands comma numeric formatting in psql
Previous Message Bruce Momjian 2005-07-12 15:26:00 Re: [PATCHES] thousands comma numeric formatting in psql

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-07-12 15:50:46 Re: [PATCHES] thousands comma numeric formatting in psql
Previous Message Bruce Momjian 2005-07-12 15:26:00 Re: [PATCHES] thousands comma numeric formatting in psql