Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.
Date: 2017-09-19 17:15:28
Message-ID: 19645.1505841328@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-09-19 13:00:33 -0400, Robert Haas wrote:
>> You mean, in the postmaster?

> Yes. We try to avoid touch shmem there, but it's not like we're
> succeeding fully. See e.g. the pgstat_get_crashed_backend_activity()
> calls (which do rely on shmem being ok to some extent), pmsignal,
> BackgroundWorkerStateChange(), ...

Well, the point is to avoid touching data structures that could be
corrupted enough to confuse the postmaster. I don't have any problem with
adding some more functionality to pmsignal, say.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-19 17:40:20 pgsql: Make new crash restart test a bit more robust.
Previous Message Andres Freund 2017-09-19 17:08:21 Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-09-19 17:28:11 Re: [GENERAL] USER Profiles for PostgreSQL
Previous Message Tom Lane 2017-09-19 17:09:54 Re: USER Profiles for PostgreSQL