Possible bug in vacuum redo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vadim Mikheev <vmikheev(at)sectorbase(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Possible bug in vacuum redo
Date: 2001-12-19 00:22:06
Message-ID: 19627.1008721326@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In the vacuum tuple-chain moving logic, shouldn't the lines that update
the new tuple's t_ctid (vacuum.c lines 1882-1891 in current sources)
be moved up to before the log_heap_move call at line 1866?

It appears to me that as the code stands, log_heap_move will log the new
tuple containing the wrong t_ctid; therefore, if we crash and have to
redo the transaction from WAL, the wrong t_ctid will be restored. No?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew G. Hammond 2001-12-19 00:29:17 Re: Explicit config patch 7.2B4
Previous Message Hiroshi Inoue 2001-12-19 00:19:54 Re: problems with table corruption continued