| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, byavuz81(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0 |
| Date: | 2022-02-11 02:02:51 |
| Message-ID: | 1959196.1644544971@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-02-10 20:25:28 -0500, Tom Lane wrote:
>> I was staring at that for awhile too. It's my own code (from 1f39a1c0641)
>> but it sure confuses me now; at the very least the code is not in sync
>> with the comment. However, it's been that way for a couple years now and
>> we've not had complaints suggesting it's broken, so maybe it's the comment
>> that's wrong.
> I wonder if it could be part of the whole "walreceiver on windows not noticing
> connection death" business.
Hmm, maybe. It sure *looks* like we need to do
- return conn->asyncStatus == PGASYNC_BUSY || conn->write_failed;
+ return conn->asyncStatus == PGASYNC_BUSY && !conn->write_failed;
If anyone who can reproduce that Windows problem wants to try that ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-11 02:18:12 | Re: BUG #17401: REINDEX TABLE CONCURRENTLY creates a race condition on a streaming replica |
| Previous Message | Andres Freund | 2022-02-11 01:54:55 | Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0 |