Re: computing completion tag is expensive for pgbench -S -M prepared

Andres Freund <andres(at)anarazel(dot)de> writes:
> ... That's actually fairly trivial to optimize - we don't
> need the full blown snprintf machinery here. A quick benchmark
> replacing it with:

> memcpy(completionTag, "SELECT ", sizeof("SELECT "));
> pg_lltoa(nprocessed, completionTag + 7);

While I don't have any objection to this change if the speedup is
reproducible, I do object to spelling the same constant as
'sizeof("SELECT ")' and '7' on adjacent lines ...

regards, tom lane