Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: Lars Kanis <kanis(at)comcard(dot)de>
To: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-12-12 14:54:15
Message-ID: 1957791.1WPFzqBR2H@c1170lx
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am Freitag, 9. Dezember 2011, 15:31:17 schrieb Andrew Dunstan:
> Yeah, fair enough. I'll work on that.

Many thanks for reviewing, tweaking and commiting the patch!
One thing I wonder about, is this snippet. Is the define really needed now?

* The Mingw64 headers choke if this is already defined - they
* define it themselves.
*/
#if !defined(__MINGW64_VERSION_MAJOR) || defined(WIN32_ONLY_COMPILER)
#define _WINSOCKAPI_
#endif
#include <winsock2.h>

Kind regards,
Lars Kanis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-12-12 15:00:37 Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Previous Message Robert Haas 2011-12-12 14:53:26 Re: [REVIEW] pg_last_xact_insert_timestamp