BUG #19555: TRAP: failed Assert (ent->cmin == change->data.tuplecid.cmin) on logical replication

The following bug has been logged on the website:

Bug reference: 19555
Logged by: Alexander Kozhemyakin
Email address: a(dot)kozhemyakin(at)postgrespro(dot)ru
PostgreSQL version: 19beta2
Operating system: ubuntu 26.04
Description:

Hi,

We've encountered an assertion failure in ReorderBufferBuildTupleCidHash
when
processing DDL operations within subtransactions. The issue reproduces on
REL_19_STABLE (commit 64542957b44).

reproduce script:

psql -c "CREATE TABLE CHAR_TBL(f1 char(4));"
psql <<EOF
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot',
'test_decoding');
CREATE TABLE xact_test(data text);
INSERT INTO xact_test VALUES ('before-test');
EOF

psql -c "create type complex as (r float8, i float8);"
psql -c "CREATE TABLE base_tbl (a int PRIMARY KEY, b text DEFAULT
'Unspecified');"
psql -c "create table copydml_test (id serial, t text);"

psql <<EOF
CREATE TABLE stream_test(data text);
INSERT INTO stream_test SELECT repeat('a', 2000) || g.i FROM
generate_series(1, 1) g(i);
TRUNCATE table stream_test;
EOF

psql -c "checkpoint;"

psql <<EOF
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL,
'include-xids', '0', 'skip-empty-xacts', '1');
CREATE TABLE tr_sub_ddl(data int);
BEGIN;
SAVEPOINT a;
ALTER TABLE tr_sub_ddl ALTER COLUMN data TYPE text;
ROLLBACK TO SAVEPOINT a;
ALTER TABLE tr_sub_ddl ALTER COLUMN data TYPE bigint;
COMMIT;
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL,
'include-xids', '0', 'skip-empty-xacts', '1');
EOF

backtrace
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=6,
no_tid=0) at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (threadid=<optimized out>, signo=6) at
./nptl/pthread_kill.c:89
#2 __GI___pthread_kill (threadid=<optimized out>, signo=signo(at)entry=6) at
./nptl/pthread_kill.c:100
#3 0x00007bfbec845b7e in __GI_raise (sig=sig(at)entry=6) at
../sysdeps/posix/raise.c:26
#4 0x00007bfbec8288ec in __GI_abort () at ./stdlib/abort.c:77
#5 0x000057ceaf77ce1c in ExceptionalCondition
(conditionName=conditionName(at)entry=0x57ceaf851c28 "ent->cmin ==
change->data.tuplecid.cmin",
fileName=fileName(at)entry=0x57ceaf8516c0
"/pgpro/postgres/src/backend/replication/logical/reorderbuffer.c",
lineNumber=lineNumber(at)entry=1890) at
/pgpro/postgres/src/backend/utils/error/assert.c:65
#6 0x000057ceaf56e58b in ReorderBufferBuildTupleCidHash (rb=0x57ceb31da6f0,
txn=0x57ceb31ee6d0) at
/pgpro/postgres/src/backend/replication/logical/reorderbuffer.c:1890
#7 ReorderBufferProcessTXN (rb=0x57ceb31da6f0, txn=0x57ceb31ee6d0,
commit_lsn=25223904, snapshot_now=<optimized out>,
command_id=command_id(at)entry=0, streaming=streaming(at)entry=false)
at /pgpro/postgres/src/backend/replication/logical/reorderbuffer.c:2220
#8 0x000057ceaf56f61c in ReorderBufferReplay (txn=<optimized out>,
rb=<optimized out>, commit_lsn=<optimized out>, end_lsn=<optimized out>,
commit_time=<optimized out>, origin_id=<optimized out>, origin_lsn=0,
xid=<optimized out>) at
/pgpro/postgres/src/backend/replication/logical/reorderbuffer.c:2870
#9 0x000057ceaf570375 in ReorderBufferCommit (rb=<optimized out>,
xid=<optimized out>, commit_lsn=<optimized out>, end_lsn=<optimized out>,
commit_time=<optimized out>, origin_id=<optimized out>,
origin_lsn=<optimized out>)
at /pgpro/postgres/src/backend/replication/logical/reorderbuffer.c:2894
#10 0x000057ceaf55db32 in DecodeCommit (ctx=0x57ceb31d66d0,
buf=0x7ffe6ad14500, parsed=0x7ffe6ad14370, xid=702, two_phase=false) at
/pgpro/postgres/src/backend/replication/logical/decode.c:755
#11 xact_decode (ctx=0x57ceb31d66d0, buf=0x7ffe6ad14500) at
/pgpro/postgres/src/backend/replication/logical/decode.c:254
#12 0x000057ceaf55d473 in LogicalDecodingProcessRecord
(ctx=ctx(at)entry=0x57ceb31d66d0, record=0x57ceb31d6af8) at
/pgpro/postgres/src/backend/replication/logical/decode.c:117
#13 0x000057ceaf564d37 in pg_logical_slot_get_changes_guts
(fcinfo=0x57ceb31c6660, confirm=confirm(at)entry=true,
binary=binary(at)entry=false) at
/pgpro/postgres/src/backend/replication/logical/logicalfuncs.c:267
#14 0x000057ceaf564ec4 in pg_logical_slot_get_changes (fcinfo=<optimized
out>) at /pgpro/postgres/src/backend/replication/logical/logicalfuncs.c:336
#15 0x000057ceaf3f3bcd in ExecMakeTableFunctionResult
(setexpr=0x57ceb31bebd8, econtext=0x57ceb31bea28, argContext=<optimized
out>, expectedDesc=0x57ceb31d8618, randomAccess=false)
at /pgpro/postgres/src/backend/executor/execSRF.c:235
#16 0x000057ceaf408c7d in FunctionNext (node=node(at)entry=0x57ceb31be818) at
/pgpro/postgres/src/backend/executor/nodeFunctionscan.c:95
#17 0x000057ceaf3f44ac in ExecScanFetch (node=<optimized out>,
epqstate=<optimized out>, accessMtd=<optimized out>, recheckMtd=<optimized
out>) at /pgpro/postgres/src/include/executor/execScan.h:135
#18 ExecScanExtended (node=<optimized out>, accessMtd=0x57ceaf408950
<FunctionNext>, recheckMtd=0x57ceaf408940 <FunctionRecheck>, epqstate=0x0,
qual=0x0, projInfo=0x57ceb31d8c58)
at /pgpro/postgres/src/include/executor/execScan.h:196
#19 ExecScan (node=0x57ceb31be818, accessMtd=0x57ceaf408950 <FunctionNext>,
recheckMtd=0x57ceaf408940 <FunctionRecheck>) at
/pgpro/postgres/src/backend/executor/execScan.c:59
#20 0x000057ceaf3e852b in ExecProcNode (node=0x57ceb31be818) at
/pgpro/postgres/src/include/executor/executor.h:327
#21 ExecutePlan (queryDesc=0x57ceb319b2e0, operation=CMD_SELECT,
sendTuples=true, numberTuples=0, direction=<optimized out>,
dest=0x57ceb31c0cc8) at /pgpro/postgres/src/backend/executor/execMain.c:1745
#22 standard_ExecutorRun (queryDesc=0x57ceb319b2e0, direction=<optimized
out>, count=0) at /pgpro/postgres/src/backend/executor/execMain.c:377
#23 0x000057ceaf60bc98 in PortalRunSelect
(portal=portal(at)entry=0x57ceb314ed40, forward=forward(at)entry=true, count=0,
count(at)entry=9223372036854775807, dest=dest(at)entry=0x57ceb31c0cc8)
at /pgpro/postgres/src/backend/tcop/pquery.c:917
#24 0x000057ceaf60d35e in PortalRun (portal=portal(at)entry=0x57ceb314ed40,
count=count(at)entry=9223372036854775807, isTopLevel=isTopLevel(at)entry=true,
dest=dest(at)entry=0x57ceb31c0cc8, altdest=altdest(at)entry=0x57ceb31c0cc8,
qc=qc(at)entry=0x7ffe6ad14b10) at
/pgpro/postgres/src/backend/tcop/pquery.c:761
#25 0x000057ceaf608e5a in exec_simple_query (query_string=0x57ceb30a0220
"SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL,
'include-xids', '0', 'skip-empty-xacts', '1');")
at /pgpro/postgres/src/backend/tcop/postgres.c:1290
#26 0x000057ceaf60aa5d in PostgresMain (dbname=<optimized out>,
username=<optimized out>) at
/pgpro/postgres/src/backend/tcop/postgres.c:4856
#27 0x000057ceaf604a03 in BackendMain (startup_data=<optimized out>,
startup_data_len=<optimized out>) at
/pgpro/postgres/src/backend/tcop/backend_startup.c:124
#28 0x000057ceaf53f461 in postmaster_child_launch (child_type=<optimized
out>, child_slot=1, startup_data=startup_data(at)entry=0x7ffe6ad14fe0,
startup_data_len=startup_data_len(at)entry=24,
client_sock=client_sock(at)entry=0x7ffe6ad15000) at
/pgpro/postgres/src/backend/postmaster/launch_backend.c:268
#29 0x000057ceaf543184 in BackendStartup (client_sock=0x7ffe6ad15000) at
/pgpro/postgres/src/backend/postmaster/postmaster.c:3627
#30 ServerLoop () at
/pgpro/postgres/src/backend/postmaster/postmaster.c:1728
#31 0x000057ceaf544e15 in PostmasterMain (argc=argc(at)entry=3,
argv=argv(at)entry=0x57ceb3047570) at
/pgpro/postgres/src/backend/postmaster/postmaster.c:1415
#32 0x000057ceaf1ceb2e in main (argc=3, argv=0x57ceb3047570) at
/pgpro/postgres/src/backend/main/main.c:231