Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Date: 2004-05-19 19:11:33
Message-ID: 19525.1084993893@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, I moved the find_my_exec calls to the locations you mentioned in
> both postgres.c and postmaster.c and remove it from main.c. I tested
> the elog and it worked.

You omitted get_pkglib_path() from the postmaster case; was that
intentional?

Also, in the non-exec case it seems unnecessary and possibly unsafe to
repeat this computation in a backend. It should inherit the settings
from the postmaster via fork(), I'd think. So possibly

#ifndef EXEC_BACKEND
if (!IsUnderPostmaster)
#endif
{
find_my_exec(...);
get_pkglib_path(...);
}

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-19 19:39:05 Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous Message Bruce Momjian 2004-05-19 19:11:26 pgsql-server/src/backend/postmaster postmaster.c

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-19 19:39:05 Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous Message Bruce Momjian 2004-05-19 19:02:10 Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p