From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization |
Date: | 2017-11-13 18:39:30 |
Message-ID: | 19508.1510598370@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
>>> [ pgbench_custom_initialization_v16.patch ]
>> I'm starting to review this patch, and I wonder how it is that you
>> ended up with "c" as the command letter for dropping existing tables.
>> Seems like "d" for DROP would be much less confusing. I see that at
>> one point "d" meant the data load step, but since you've gone with
>> "g" for "generate data" that conflict is gone.
> Indeed, you are right. As a reviewer, I can recall that there were some
> hesitations, not sure we ended up with the best possible choice.
OK, will make the appropriate changes.
> Note that if "c" is freed by "d" (drop), then it may be worth considering
> that "t" (table) could be replaced by "c" (create).
I thought about that, but the argument that 'c' might mean different
sorts of create steps (e.g. create index) seemed reasonable. I think
we're best off leaving it as 't' in case of future expansion.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-11-13 18:39:33 | Re: [HACKERS] No mention of CREATE STATISTICS in event trigger docs |
Previous Message | Fabien COELHO | 2017-11-13 18:31:33 | Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization |