| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2025-12-08 09:51:36 |
| Message-ID: | 19490.1765187496@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> Some comments for 0003:
>
> > /* allocate in transaction context */
> It may be any context now, because it is a function now.
Inaccuracy not introduced by REPACK, but I think it's o.k. if the next version
of this patch will remove the comment.
> > result = CopySnapshot(snapshot);
>
> > /* Restore the original values so the source is intact. */
> > snapshot->xip = oldxip;
> > snapshot->xcnt = oldxcnt;
>
> I think it is worth to call pfree(newxip) here.
ok
> > "This difference does has no impact"
>
> should be "This difference has no impact"?
Right, thanks.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-12-08 09:51:40 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Amit Kapila | 2025-12-08 09:46:54 | Re: Newly created replication slot may be invalidated by checkpoint |