Re: failing to build preproc.c on solaris with sun studio

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: failing to build preproc.c on solaris with sun studio
Date: 2022-08-07 05:17:22
Message-ID: 193604.1659849442@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-08-06 22:55:14 -0400, Tom Lane wrote:
>> IMO, it'd be entirely reasonable for Andres to say that *he* doesn't
>> want to fix the meson build scripts for niche platform X. Then
>> it'd be up to people who care about platform X to make that happen.
>> Given the current plan of supporting the Makefiles for some years
>> more, there wouldn't even be any great urgency in that.

> The "problem" in this case is that maintaining pgxs compatibility, as we'd
> discussed at pgcon, requires emitting stuff for all the @whatever@ things in
> Makefile.global.in, including with_gnu_ld.

Sure, but why can't you just leave that for later by hard-wiring it
to false in the meson build? As long as you don't break the Makefile
build, no one is worse off.

I think if we want to get this past the finish line, we need to
acknowledge that the initial commit isn't going to be perfect.
The whole point of continuing to maintain the Makefiles is to
give us breathing room to fix remaining issues in a leisurely
fashion.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-08-07 06:20:26 Re: Cleaning up historical portability baggage
Previous Message Bharath Rupireddy 2022-08-07 05:11:49 Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?