Re: pgsql: Fix timing issue in new subscription truncate test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: pgsql: Fix timing issue in new subscription truncate test
Date: 2018-04-07 17:22:07
Message-ID: 1930.1523121727@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On April 7, 2018 9:59:34 AM PDT, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> We need to wait for the initial sync of all subscriptions. On
>> some (faster?) machines, this didn't make a difference, but
>> the (slower?) buildfarm machines are upset.

> Failed on my very fast laptop fwiw.

I'm a bit suspicious of that analysis too, as it was the faster buildfarm
machines that were reporting the first wave of failures. (A lot of the
slow ones aren't configured to run subscription-check at all, I think.)

Testing the fix here, I just noticed that there's a pre-existing
problem in subscription/t/002_types.pl. It passes make check OK,
but make installcheck not so much. Investigating ...

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-07 17:31:53 Re: pgsql: Fix timing issue in new subscription truncate test
Previous Message Simon Riggs 2018-04-07 17:19:19 Re: pgsql: New files for MERGE