Re: SetBufferCommitInfoNeedsSave and race conditions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SetBufferCommitInfoNeedsSave and race conditions
Date: 2007-06-28 19:16:15
Message-ID: 19267.1183058175@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> AFAICS, we can just simply remove the assertion. But is there any
> codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all
> appropriate hint bits are set?

There had better not be, since we are going to postpone setting hint
bits for recently-committed transactions as part of the async-commit
patch.

A quick grep suggests that VACUUM FULL might be at risk here.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-06-28 19:29:48 Re: SetBufferCommitInfoNeedsSave and race conditions
Previous Message Tom Lane 2007-06-28 19:09:38 Re: write past chunk end in ExprContext / to_char