Re: [FEATURE PATCH] pg_stat_statements with plans (v02)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>, legrand legrand <legrand_legrand(at)hotmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, marius(dot)timmer(at)uni-muenster(dot)de, arne(dot)scheffer(at)uni-muenster(dot)de
Subject: Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
Date: 2018-08-20 13:09:04
Message-ID: 19237.1534770544@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-08-20 15:21:07 +1200, Thomas Munro wrote:
>> -Werror=vla in GCC, apparently.

> How about detecting support for that in our configure script and
> automatically using it? If we're uncomfortable with raising an error,
> let's at least raise a warning?

Yeah, we'd certainly auto-turn-on whatever options we think are needed.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-20 13:14:36 Re: remove ATTRIBUTE_FIXED_PART_SIZE
Previous Message Andres Freund 2018-08-20 12:50:22 Re: ALTER TABLE on system catalogs