| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid repeated scans of the output buffer in oidvectortypes() |
| Date: | 2026-10-15 13:49:21 |
| Message-ID: | 1919824.1792072161@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Fri, 16 Oct 2026 at 01:16, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> * v1 was slightly faster in my test. With debug and assertions disabled, v1 took about 20 ms and StringInfo about 24 ms, averaged over multiple runs.
> I doubt that matters very much.
I don't understand why we should spend any time whatsoever on
optimizing oidvectorout. There are epsilon real-world use-cases
that depend on that function, and surely none at all that care
about vectors longer than FUNC_MAX_ARGS or so. We have much
better places to spend our time.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-10-15 13:52:30 | Re: Avoid repeated scans of the output buffer in oidvectortypes() |
| Previous Message | Johannes Edmeier | 2026-10-15 13:43:21 | Re: [PATCH] Halve peak memory allocation for toast_flatten_tuple |