Re: BUG #8335: trim() un-document behaviour

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: amutu(at)amutu(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8335: trim() un-document behaviour
Date: 2013-08-09 15:06:15
Message-ID: 19166.1376060775@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> The attached patch swaps the arguments in the parser, and allows your
> expected behavior:

This patch is completely unsafe. It will break stored rules, which may
contain calls using the existing argument order (which will be dumped
without any of the SQL-spec syntactic sugar). To say nothing of existing
applications that may be relying on calling the underlying functions with
their existing argument order.

The inconsistency in argument order is unfortunate but we're long since
stuck with it, I'm afraid.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Kevin Grittner 2013-08-09 16:06:22 Re: How to avoid Force Autovacuum
Previous Message ascot.moss@gmail.com 2013-08-09 14:17:50 Re: Recovery.conf and PITR by recovery_target_time

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2013-08-09 15:08:52 Re: mvcc catalo gsnapshots and TopTransactionContext
Previous Message David Fetter 2013-08-09 14:58:16 Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])