From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Karl Lehenbauer <karl(at)flightaware(dot)com> |
Subject: | Re: Add support for SRF and returning composites to pl/tcl |
Date: | 2016-11-08 14:33:34 |
Message-ID: | 19165.1478615614@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> writes:
> Hrm, I completely spaced on the fact that composite returns are
> essentially the same thing as trigger returns. ISTM we should be able to
> use the same code for both. IIRC those magic elements could end up in
> any SPI result, so that handling certainly needs to be the same.
> Have you had a chance to look at this or should I?
As things stand in HEAD, the behavior is about the same, but the error
messages are not --- in one case they mention triggers and of course the
other doesn't. There are a couple of other minor things in the way of
unifying the two hunks of code, so I concluded it probably wasn't worth
the trouble. But feel free to take another look if it bugs you.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-11-08 14:39:05 | Re: Fix bug in handling of dropped columns in pltcl triggers |
Previous Message | Jim Nasby | 2016-11-08 14:27:57 | Re: C based plugins, clocks, locks, and configuration variables |