| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Sait Talha Nisanci <Sait(dot)Nisanci(at)microsoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Metin Doslu <Metin(dot)Doslu(at)microsoft(dot)com> |
| Subject: | Re: [EXTERNAL] Re: Crash in record_type_typmod_compare |
| Date: | 2021-07-10 17:58:29 |
| Message-ID: | 1913a3e8399214325b8ee61c09608a64a7d81eb5.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2021-04-05 at 12:07 +0000, Sait Talha Nisanci wrote:
> Hi Andres,
>
> Please see the updated patch, do you mean something like this? (there
> might be a simpler way for doing this)
>
Committed with minor revisions.
My patch also avoids incrementing NextRecordTypmod until we've already
called CreateTupleDescCopy(). Otherwise, an allocation failure could
leave NextRecordTypmod unnecessarily incremented, which is a tiny leak.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2021-07-10 18:19:12 | Re: pgsql: Fix numeric_mul() overflow due to too many digits after decimal |
| Previous Message | Tom Lane | 2021-07-10 17:30:42 | Re: pgsql: Fix numeric_mul() overflow due to too many digits after decimal |