| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, william allen <williamedwinallen(at)live(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15858: could not stat file - over 4GB |
| Date: | 2020-09-17 16:04:57 |
| Message-ID: | 190302.1600358697@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo(dot)santamaria(at)gmail(dot)com> writes:
> Thanks for the reminder. Please find attached a rebased version.
(This hasn't shown up on -hackers yet, maybe caught in moderation?)
I took a quick look through this. I'm not qualified to review the
actual Windows code in win32stat.c, but as far as the way you're
plugging it into the system goes, it looks good and seems to comport
with the discussion so far.
One thing I noticed, which is a pre-existing problem but maybe now
is a good time to consider it, is that we're mapping lstat() to be
exactly stat() on Windows. That made sense years ago when (we
believed that) Windows didn't have symlinks, but surely it no longer
makes sense.
Another more trivial point is that it'd be good to run the new code
through pgindent before committing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-09-17 18:13:44 | Re: BUG #15858: could not stat file - over 4GB |
| Previous Message | Juan José Santamaría Flecha | 2020-09-17 15:16:15 | Re: BUG #15858: could not stat file - over 4GB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-09-17 16:34:26 | Re: WIP: BRIN multi-range indexes |
| Previous Message | Tom Lane | 2020-09-17 15:39:56 | Re: pgindent vs dtrace on macos |