| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Юрий Соколов <funny(dot)falcon(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |
| Date: | 2020-02-27 06:03:07 |
| Message-ID: | 18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/02/27 7:43, Peter Geoghegan wrote:
> On Mon, Feb 24, 2020 at 4:54 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>> Attached is v34, which has this change. My plan is to commit something
>> very close to this on Wednesday morning (barring any objections).
>
> Pushed.
Thanks for committing this nice feature!
Here is one minor comment.
+ <primary><varname>deduplicate_items</varname></primary>
+ <secondary>storage parameter</secondary>
This should be
<primary><varname>deduplicate_items</varname> storage parameter</primary>
<secondary> for reloption is necessary only when the GUC parameter
with the same name of the reloption exists. So, for example, you can
see that <secondary> is used in vacuum_cleanup_index_scale_factor
but not in buffering reloption.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takuma Hoshiai | 2020-02-27 06:06:49 | Re: Implementing Incremental View Maintenance |
| Previous Message | Yugo NAGATA | 2020-02-27 06:00:38 | Re: Allow auto_explain to log plans before queries are executed |