BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)

From: PG Bug reporting form <noreply(at)postgresql(dot)org>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: d(dot)kovalenko(at)postgrespro(dot)ru
Subject: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)
Date: 2025-06-18 19:25:04
Message-ID: 18960-09cd4a5100152e58@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

The following bug has been logged on the website:

Bug reference: 18960
Logged by: Dmitry Kovalenko
Email address: d(dot)kovalenko(at)postgrespro(dot)ru
PostgreSQL version: 18beta1
Operating system: any
Description:

Hello,
Please look at these test lines in
src/test/modules/libpq_pipeline/libpq_pipeline.c 1657-1662:
https://github.com/postgres/postgres/blob/c2e2589ab969eb802493191c79de844bf7dc3a6e/src/test/modules/libpq_pipeline/libpq_pipeline.c#L1657-L1662
---
PQclear(res);
res = NULL;
if (PQgetResult(conn) != NULL)
pg_fatal("PQgetResult returned something extra after
pipeline end: %s",
PQresStatus(PQresultStatus(res)));
---
You forgot to assign res:
---
PQclear(res);
res = NULL;
if ((res = PQgetResult(conn)) != NULL)
pg_fatal("PQgetResult returned something extra after
pipeline end: %s",
PQresStatus(PQresultStatus(res)));
---
Thanks&Regards,
Dmitry Kovalenko
PostgresPro, Russia.

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2025-06-18 20:46:54 Re: PostgreSQL 17 Service Running but Not Listening on Network Port on Windows
Previous Message Tom Lane 2025-06-18 16:46:35 Re: BUG #18959: Name collisions of expression indexes during parallel Index creations on a pratitioned table.