Re: Fixing cache pollution in the Kerberos test suite

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing cache pollution in the Kerberos test suite
Date: 2021-01-25 19:04:34
Message-ID: 1895343.1611601474@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jacob Champion <pchampion(at)vmware(dot)com> writes:
> On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote:
>> Yeah, changing global state is just awful. However, I don't
>> actually see any change here (RHEL8):

> Interesting. I'm running Ubuntu 20.04:

Hmm. I'll poke harder.

>> Also, why are you only setting the ENV variable within narrow parts
>> of the test script? I'd be inclined to enforce it throughout.

> I considered it and decided I didn't want to pollute the server's
> environment with it, since the server shouldn't need the client cache.

True, but if it did try to access the cache, accessing the user's
normal cache would be strictly worse than accessing the test cache.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-01-25 19:08:27 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Jacob Champion 2021-01-25 19:00:41 Re: Fixing cache pollution in the Kerberos test suite