Re: REPACK (ANALYZE) within transaction block segfaults

Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com> wrote:

> I've updated the patch to address your comments:
>
> * Documented that 'REPACK (ANALYZE)' cannot be used inside a transaction block, or from a function, procedure or 'DO' block.
> * Updated the comment in repack.c to clarify that this restriction is intentional for now, consistently with VACUUM (FULL, ANALYZE).

In [1] I added a comment explaining why it's a problem to run REPACK (ANALYZE)
from function. I thought it's important so that, when we conclude (in the
future) that running in block is fine, we still keep checking for execution
from a function. (PreventInTransactionBlock() checks both at the moment.)

In [2] I was advised to make the comment more precise, but as you appear to
have taken the patch over, I expected that you'll do that. However, you simply
removed that part of the comment. Can you please explain why?

BTW, "top posting" is not the preferred style in this mailing list [3].

[1] https://www.postgresql.org/message-id/49398.1787944525%40localhost
[2] https://www.postgresql.org/message-id/CAHGQGwEezdMUixhJ-N0YO0OFUmh0uPaXRDkds5FS-5dmdwz4Bg%40mail.gmail.com
[3] https://wiki.postgresql.org/wiki/Mailing_Lists

--
Antonin Houska
Web: https://www.cybertec-postgresql.com