| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Petr Fedorov <petr(dot)fedorov(at)phystech(dot)edu> |
| Subject: | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |
| Date: | 2020-09-09 13:38:31 |
| Message-ID: | 1893468.1599658711@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2020-09-07 01:46, Tom Lane wrote:
>> I reviewed the 0002 patch, finding one bug (in int8_sum)
> Ouch, no test coverage. Should we perhaps remove this function, since
> it's obsolete and unused?
I don't feel a need to.
>> and a few
>> more calls of int8_numeric that could be converted. I think the
>> attached updated version is committable, and I'd recommend going
>> ahead with that regardless of the rest of this. I hadn't realized
>> how many random calls of int8_numeric and int4_numeric we'd grown,
>> but there are a lot, so this is nice cleanup.
> Yes, please go ahead with it.
It's your patch, I figured you'd want to commit it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2020-09-09 13:59:35 | BUG #16611: devel package installation issue.When tried to installed the PostgreSQL 11.0 version ecpg not get |
| Previous Message | Michael Paquier | 2020-09-09 12:46:34 | Re: BUG #16577: Segfault on altering a table located in a dropped tablespace |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2020-09-09 13:41:30 | Re: Online checksums verification in the backend |
| Previous Message | Etsuro Fujita | 2020-09-09 13:37:07 | Minor cleanup of partbounds.c |