From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: NULL checks of deferenced pointers in picksplit method of intarray |
Date: | 2015-02-16 21:49:39 |
Message-ID: | 1885338644.4651964.1424123379545.JavaMail.yahoo@mail.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> Coverity is pointing out that _int_split.c has unnecessary checks
> for deferenced pointers in 5 places.
> Attached is a patch to adjust those things.
Pushed. Thanks!
> Also, as far as I understood from this code, no elements
> manipulated are NULL, perhaps this is worth an assertion?
I'm not clear where you were thinking of, but anyway that seemed
like a separate patch if we're going to do it, so I went ahead with
pushing the issued Coverity flagged. The arguments to the function
don't need such a check because the function is exposed to SQL with
the STRICT option (but you probably already knew that). While
reviewing the safety of this patch the only place that I ran across
that I felt maybe deserved an assertion was that n >= 0 near the
top of copy_intArrayType(), but that seems marginal.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2015-02-16 21:59:16 | Re: TABLESAMPLE patch |
Previous Message | Peter Eisentraut | 2015-02-16 21:47:23 | Re: pgsql: pg_upgrade: quote directory names in delete_old_cluster script |