Re: CSV arm check failure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Jim Buttafuoco <jim(at)contactbda(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CSV arm check failure
Date: 2005-01-06 19:05:17
Message-ID: 18725.1105038317@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Marko Kreen <marko(at)l-t(dot)ee> writes:
> I have not looked at pg_regress much and had not noticed the
> 'unconditional alternative' feature. I only thought of the
> resultmap alternative. Unconditionally adding FastFPE results
> may even be good, so that FastFPE can pass on any platform.

No, it would be bad, because on most other platforms this behavior
is probably a bug, and altering the tests like that would mask the bug.

The unconditional-acceptance thing has to be used with great caution;
preferably only for issues that we expect on many platforms (such as
locale dependencies).

I have noticed an increasing tendency among the buildfarm crew to think
that the regression tests should show zero diffs on all platforms no
matter what. That is not the design goal. The intent is to tell you
about possible problems. If you decide that a particular diff isn't
really a problem, fine, but that doesn't mean we should mask the same
symptom everywhere.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-01-06 19:35:52 Re: CSV arm check failure
Previous Message Marko Kreen 2005-01-06 18:18:58 Re: CSV arm check failure