"Ryan Bradetich" <rbradetich(at)gmail(dot)com> writes:> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:>> [ something about "your patch" ]
> This is Robert Haas's patch for the September 2008 commit-fest.> I am just offering my review.
Sorry about that, I got confused by the reply-to-a-reply.
> Does my first suggestion still make sense for removing the TRUNCATE in> pg_class_aclmask() when pg_Authid.rolcatupdate is not set?
Probably. AFAICS it should be treated exactly like ACL_DELETE, soanyplace that acl-whacking code is doing something for ACL_DELETE andthe patch doesn't add in ACL_TRUNCATE, I'd be suspicious ...
regards, tom lane