From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add support for temporary replication slots |
Date: | 2016-12-13 00:40:37 |
Message-ID: | 18684.1481589637@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> On 13/12/16 00:39, Tom Lane wrote:
>> Hm, buildfarm says this didn't fix it. Where exactly does the dropping
>> of the slot happen ... is it not complete by the time the backend exits?
> Yes, I've seen. The cleanup of slots is done in ProcKill(), I wonder,
> since it's on_shmem_exit hook, and the pgstat_beshutdown_hook is as
> well, maybe the pgstat_beshutdown_hook is called before ProcKill and the
> query is lucky to hit right in between.
Hm. That seems like a pretty bogus place to do it. An awful lot of the
backend infrastructure is already gone by then, if I recall the ordering
correctly. Maybe ShutdownPostgres would be a saner place; but it really
depends on what you think the module layering is for this facility.
I would definitely not think it is proc.c's responsibility, though.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2016-12-13 00:42:48 | Re: pgsql: Add support for temporary replication slots |
Previous Message | Petr Jelinek | 2016-12-13 00:05:08 | Re: pgsql: Add support for temporary replication slots |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2016-12-13 00:42:48 | Re: pgsql: Add support for temporary replication slots |
Previous Message | Nikita Glukhov | 2016-12-13 00:38:59 | PATCH: recursive json_populate_record() |