| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep |
| Date: | 2021-07-27 17:23:18 |
| Message-ID: | 1863E868-AD2E-4BEB-A9A6-DFD9A231C657@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/26/21, 10:34 PM, "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> PSA v3 patch.
LGTM. The pre/post_auth_delay parameters seem to work as intended,
and they are responsive to postmaster crashes. I didn't find any
examples of calling WaitLatch() without WL_LATCH_SET, but the function
appears to have support for that. (In fact, it just sets the latch
variable to NULL in that case, so perhaps we should replace MyLatch
with NULL in the patch.) I do see that WaitLatchOrSocket() is
sometimes called without WL_LATCH_SET, though.
I am marking this patch as ready-for-committer.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-07-27 17:48:13 | Re: .ready and .done files considered harmful |
| Previous Message | Andres Freund | 2021-07-27 17:22:57 | Re: Minimal logical decoding on standbys |