Re: Archiver not exiting upon crash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Archiver not exiting upon crash
Date: 2012-05-21 16:52:59
Message-ID: 18587.1337619179@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> You might have gotten the following problem which was discussed before.
>> This problem was fixed in SIGQUIT signal handler of a backend, but ISTM
>> not that of an archiver.
>> http://archives.postgresql.org/pgsql-admin/2009-11/msg00088.php

> pgarch.c's SIGQUIT handler just does exit(1), so it seems a bit unlikely
> that that solution would make a difference.

... but having said that, I see Peter's commit
d6de43099ac0bddb4b1da40088487616da892164 only touched postgres.c's
quickdie(), and not all the *other* background processes with identical
coding. That seems a clear oversight, so I will go fix it. Doesn't
explain why the archiver would get confused, though, since that file
doesn't have any code that tries to re-enable signals after entering the
signal handler.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-05-21 16:58:21 Re: External Open Standards
Previous Message Peter Eisentraut 2012-05-21 16:52:45 Re: External Open Standards