Re: pgsql/src/bin/pg_dump pg_dumpall.sh

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/bin/pg_dump pg_dumpall.sh
Date: 2002-04-11 20:56:00
Message-ID: 18557.1018558560@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

momjian(at)postgresql(dot)org (Bruce Momjian - CVS) writes:
> Modified files:
> src/bin/pg_dump: pg_dumpall.sh

> Log message:
> Fix pg_upgrade to handle dbnames, user/group names with spaces.

I think it's illusory to imagine that this fixes the issue. Unless
"read"'s behavior is more tightly specified than I think, you are still
gonna have trouble with leading, trailing, or consecutive blanks.

I'm also concerned that you've opened up portability issues concerning
newlines embedded in shell literals (eg, does that sed command portably
do what you think?).

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2002-04-11 21:03:01 Re: pgsql/src/bin/pg_dump pg_dumpall.sh
Previous Message Tom Lane 2002-04-11 20:00:19 pgsql/ oc/src/sgml/catalogs.sgml oc/src/sgml/r ...