Re: Adding CI to our tree

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Adding CI to our tree
Date: 2021-10-21 16:35:08
Message-ID: 184c7dae-c750-3834-43c2-1316e6efc5ac@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/21/21 5:55 PM, Matthias van de Meent wrote:
> On Sat, 2 Oct 2021 at 17:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> It's not like this forces you to use cirrus or anything. For people that don't
>>> want to use CI, It'll make cfbot a bit more effective (because people can
>>> adjust what it tests as appropriate for $patch), but that's it.
>
> I don't disagree on that part, but I fail to see what makes the
> situations of an unused CI config file in the tree and an unused
> `/.idea/` or `/.vs/` specifier in the .gitignore [0][1] distinct
> enough for it to be resolved differently. Both are quality-of-life
> additions for those that use that tool, while non-users of that tool
> can ignore those configuration entries.

There is a better solution to that. Just add those files to the global
gitignore on your machine. You will want to ignore those files in all
git repositories on your machine anyway. On the other hand the
configuration files for the CI are relevant to just the PostgreSQL repo.

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-10-21 17:10:21 Re: Drop replslot after pgstat_shutdown cause assert coredump
Previous Message Jeremy Schneider 2021-10-21 16:12:14 Re: relation OID in ReorderBufferToastReplace error message