| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Retire src/backend/port/dynloader/linux.c ? |
| Date: | 2016-12-19 03:25:40 |
| Message-ID: | 183abd56-40cf-1c26-f027-7b4d6ee868a3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/18/16 10:19 PM, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> Shouldn't we just remove that code?
>
> What for? It's maintenance-free ... hasn't been touched since 2004.
> While I agree with you that it's *probably* dead code, it's hard to
> see much upside from removing it.
>
> If we want to get into arguing whether code is dead or not, there's
> an awful lot of potentially removable stuff in the tree, but I doubt
> it's worth the trouble to figure out what's really dead.
If someone wants to dive into it, I think you could probably remove most
or all of the prehistoric pre-dlopen code for *bsd and darwin as well.
The hpux and win32 code could be moved to libpgport, and then we could
just call dlopen() etc. directly and remove this whole subdirectory.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2016-12-19 03:33:15 | Re: Creating a DSA area to provide work space for parallel execution |
| Previous Message | Tom Lane | 2016-12-19 03:19:36 | Re: Retire src/backend/port/dynloader/linux.c ? |