Re: Win32 defines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 defines
Date: 2003-04-16 15:26:44
Message-ID: 18367.1050506804@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Why is this removing the use of the TIMEZONE_GLOBAL macro?

> It was Peter's suggestion. Once we had a port-specific define, we
> should use timezone directly, no?

> #define timezone _timezone

Oh, I missed that part. A bit risky IMHO --- the macro might expand in
places you didn't expect/want. TIMEZONE_GLOBAL is unlikely to cause
any such conflict ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Sean Chittenden 2003-04-16 15:45:17 Re: Are we losing momentum?
Previous Message Bruce Momjian 2003-04-16 14:51:55 Re: Win32 defines