Re: pgsql: pg_ctl: Detect current standby state from pg_control

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_ctl: Detect current standby state from pg_control
Date: 2016-09-25 15:54:47
Message-ID: 18364.1474818887@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> pg_ctl: Detect current standby state from pg_control

Coverity thinks that this patch introduced a bunch of
null-pointer-dereference hazards, and AFAICS it is right.
The change in get_controlfile()'s API is completely broken
and needs to be undone.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-09-25 19:41:20 pgsql: Refer to OS X as "macOS", except for the port name which is stil
Previous Message Tom Lane 2016-09-24 20:25:44 pgsql: Do a final round of updates on the 9.6 release notes.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-09-25 16:01:00 Re: Possibly too stringent Assert() in b-tree code
Previous Message Tom Lane 2016-09-25 15:43:44 Re: Development build with uuid-ossp support - macOS