Re: identify_locking_dependencies is broken for schema-only dumps

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: identify_locking_dependencies is broken for schema-only dumps
Date: 2014-09-24 16:18:48
Message-ID: 18320.1411575528@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> If there are no comments on this soon-ish, I'm going to push and
> back-patched the patch I attached.

Sorry for not paying attention sooner. After studying it for awhile,
I think the change is probably all right but your proposed comment is
entirely inadequate. There are extremely specific reasons why this
works, and you removed an existing comment about that and replaced it
with nothing but a wishy-washy "maybe".

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-09-24 16:44:09 Re: better atomics - v0.6
Previous Message Andres Freund 2014-09-24 16:00:47 Re: better atomics - v0.6